Recent Posts1
MegaMek Games / Issue with Salvage %
« Last post by DamnKerensky on Today at 12:08:14 »I've known for years that there was something wrong with the way the percents are calculated in the salvage ownership step, but it seemed to be beneficial to me *and reasonably consistent*, so it didn't seem to be worth bringing up. But this is just egregiously strange and cannot possibly be hand-waved away as "oh, its just your settings."
With ownership of all salvage going to employer:
Total value salvaged (Mercs): 29,382,439 C-Bill
Total value salvaged (Employer): 70,183,956 C-Bill
Percentage: 30% (max 30%)
But if I select a few cheap pieces of salvage for myself, then my percentage DECREASES ?!?!
Total value salvaged (Mercs): 29,854,145 C-Bill
Total value salvaged (Employer): 69,712,250 C-Bill
Percentage: 29% (max 30%)
As someone who ages ago was (sort of) a coder, I wonder ... How in the world could this code be written to display this sort of behavior?! Actually, let me answer my own question - I'm guessing there are two different places where the percentage is calculated and they are doing the rounding differently (?)
(To save people the effort of doing it themselves, the true percentages above are 29.51% and 29.98%)
How this affects play:
Normally (assuming there is a lot that I want to claim in this batch of salvage) I might select a bunch of vehicle salvage until I am somewhere around 30.8% then choose a mech as my final piece of salvage and go to perhaps ... 32 or 33%.
But if I am over my limit from my previous fight, and the new batch of salvage means I am at, for example, 30.6% before anything is chosen, then it rounds up to 31% and I am not allowed to choose anything at all.
In one case, the program lets me continue claiming salvage even if I am at 30.99%, while in a different case I am not allowed to claim anything at all if I am at 30.51% This is not broken, but at the very least it is a strange design choice (from my perspective).
To be clear, this isn't a show-stopper by any stretch. The game is still very playable. I just feel like this is representative of the MANY tiny bugs/weird-design-choices (and a few not so tiny ones) in MM that aren't being addressed while more and more new features are added.
With ownership of all salvage going to employer:
Total value salvaged (Mercs): 29,382,439 C-Bill
Total value salvaged (Employer): 70,183,956 C-Bill
Percentage: 30% (max 30%)
But if I select a few cheap pieces of salvage for myself, then my percentage DECREASES ?!?!
Total value salvaged (Mercs): 29,854,145 C-Bill
Total value salvaged (Employer): 69,712,250 C-Bill
Percentage: 29% (max 30%)
As someone who ages ago was (sort of) a coder, I wonder ... How in the world could this code be written to display this sort of behavior?! Actually, let me answer my own question - I'm guessing there are two different places where the percentage is calculated and they are doing the rounding differently (?)
(To save people the effort of doing it themselves, the true percentages above are 29.51% and 29.98%)
How this affects play:
Normally (assuming there is a lot that I want to claim in this batch of salvage) I might select a bunch of vehicle salvage until I am somewhere around 30.8% then choose a mech as my final piece of salvage and go to perhaps ... 32 or 33%.
But if I am over my limit from my previous fight, and the new batch of salvage means I am at, for example, 30.6% before anything is chosen, then it rounds up to 31% and I am not allowed to choose anything at all.
In one case, the program lets me continue claiming salvage even if I am at 30.99%, while in a different case I am not allowed to claim anything at all if I am at 30.51% This is not broken, but at the very least it is a strange design choice (from my perspective).
To be clear, this isn't a show-stopper by any stretch. The game is still very playable. I just feel like this is representative of the MANY tiny bugs/weird-design-choices (and a few not so tiny ones) in MM that aren't being addressed while more and more new features are added.
